Skip to content

[Backport] Add additional check if password hash is empty in auth process#19110

Merged
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
agorbulin:2.2-develop-PR-port-19066
Nov 9, 2018
Merged

[Backport] Add additional check if password hash is empty in auth process#19110
magento-engcom-team merged 1 commit intomagento:2.2-developfrom
agorbulin:2.2-develop-PR-port-19066

Conversation

@agorbulin
Copy link

@agorbulin agorbulin commented Nov 7, 2018

Original Pull Request

#19066

Description

Added additional check for password hash if the customer was created without a password from admin area.

Fixed Issues

  1. User created by admin cannot login #19060: User created by admin cannot login

Manual testing scenarios

  1. Create customer at admin area (without password)
  2. Try to login at frontend as a customer

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team magento-engcom-team added Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner labels Nov 7, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 7, 2018

Hi @agorbulin. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 8, 2018
@VladimirZaets VladimirZaets self-assigned this Nov 9, 2018
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 9, 2018

Hi @VladimirZaets, thank you for the review.
ENGCOM-3411 has been created to process this Pull Request

@magento-engcom-team magento-engcom-team mentioned this pull request Nov 9, 2018
Closed
@magento-engcom-team magento-engcom-team merged commit 35c2345 into magento:2.2-develop Nov 9, 2018
magento-engcom-team pushed a commit that referenced this pull request Nov 9, 2018
ENGCOM-3411: [Backport] Add additional check if password hash is empt…
3c868a5 
…y in auth process #19110
@magento-engcom-team
Copy link
Contributor

magento-engcom-team commented Nov 9, 2018

Hi @agorbulin. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VladimirZaets VladimirZaets VladimirZaets approved these changes

Assignees

@rogyar rogyar

@VladimirZaets VladimirZaets

Labels

Component: Customer Partner: ISM eCompany Pull Request is created by partner ISM eCompany partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Milestone

Release: 2.2.8

Development

Successfully merging this pull request may close these issues.

6 participants

@agorbulin @magento-engcom-team @mikekeilty @VladimirZaets @rogyar @progreg